Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newsletter subscription PR fixes - and fix "To home page" button not closing dialog #212

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

jongomez
Copy link
Contributor

@jongomez jongomez commented Oct 26, 2023

Description:

Implement fixes for the following PR: #211

The fixes were suggested by @jeangovil

Also fixes the "To home page" button not closing dialog

Related Issue(s):

(none)

Changes Included:

  • Bugfix (a change that fixes an issue)
  • New feature (a change that adds new functionality)
  • Refactoring (a change that improves code quality and/or architecture)
  • Other (explain below)

Implementation Details:

Just some refactoring and a bug fix, nothing fancy.

Testing:

If we use the email [email protected] - we can now trigger the success state. We can also trigger the error state by using the email [email protected]

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@vercel
Copy link

vercel bot commented Oct 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
lpe ✅ Ready (Inspect) Visit Preview Oct 26, 2023 5:06pm

@jongomez jongomez merged commit 58c8b31 into develop Oct 26, 2023
4 checks passed
@jongomez jongomez deleted the email-subscription-pr-fixes branch October 26, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants